New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for React Native #179
Closed
Closed
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,66 @@ | ||
import re | ||
|
||
# To learn about Buck see [Docs](https://buckbuild.com/). | ||
# To run your application with Buck: | ||
# - install Buck | ||
# - `npm start` - to start the packager | ||
# - `cd android` | ||
# - `keytool -genkey -v -keystore keystores/debug.keystore -storepass android -alias androiddebugkey -keypass android -dname "CN=Android Debug,O=Android,C=US"` | ||
# - `./gradlew :app:copyDownloadableDepsToLibs` - make all Gradle compile dependencies available to Buck | ||
# - `buck install -r android/app` - compile, install and run application | ||
# | ||
|
||
lib_deps = [] | ||
for jarfile in glob(['libs/*.jar']): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do people normally add dependencies to source control or manage them through maven/ivy etc for android apps? This isn't important right now, I'm mostly asking to make sure I'm understanding what's going on. |
||
name = 'jars__' + re.sub(r'^.*/([^/]+)\.jar$', r'\1', jarfile) | ||
lib_deps.append(':' + name) | ||
prebuilt_jar( | ||
name = name, | ||
binary_jar = jarfile, | ||
) | ||
|
||
for aarfile in glob(['libs/*.aar']): | ||
name = 'aars__' + re.sub(r'^.*/([^/]+)\.aar$', r'\1', aarfile) | ||
lib_deps.append(':' + name) | ||
android_prebuilt_aar( | ||
name = name, | ||
aar = aarfile, | ||
) | ||
|
||
android_library( | ||
name = 'all-libs', | ||
exported_deps = lib_deps | ||
) | ||
|
||
android_library( | ||
name = 'app-code', | ||
srcs = glob([ | ||
'src/main/java/**/*.java', | ||
]), | ||
deps = [ | ||
':all-libs', | ||
':build_config', | ||
':res', | ||
], | ||
) | ||
|
||
android_build_config( | ||
name = 'build_config', | ||
package = 'com.happo', | ||
) | ||
|
||
android_resource( | ||
name = 'res', | ||
res = 'src/main/res', | ||
package = 'com.happo', | ||
) | ||
|
||
android_binary( | ||
name = 'app', | ||
package_type = 'debug', | ||
manifest = 'src/main/AndroidManifest.xml', | ||
keystore = '//android/keystores:debug', | ||
deps = [ | ||
':app-code', | ||
], | ||
) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,148 @@ | ||
apply plugin: "com.android.application" | ||
|
||
import com.android.build.OutputFile | ||
|
||
/** | ||
* The react.gradle file registers a task for each build variant (e.g. bundleDebugJsAndAssets | ||
* and bundleReleaseJsAndAssets). | ||
* These basically call `react-native bundle` with the correct arguments during the Android build | ||
* cycle. By default, bundleDebugJsAndAssets is skipped, as in debug/dev mode we prefer to load the | ||
* bundle directly from the development server. Below you can see all the possible configurations | ||
* and their defaults. If you decide to add a configuration block, make sure to add it before the | ||
* `apply from: "../../../node_modules/react-native/react.gradle"` line. | ||
* | ||
* project.ext.react = [ | ||
* // the name of the generated asset file containing your JS bundle | ||
* bundleAssetName: "index.android.bundle", | ||
* | ||
* // the entry file for bundle generation | ||
* entryFile: "index.android.js", | ||
* | ||
* // whether to bundle JS and assets in debug mode | ||
* bundleInDebug: false, | ||
* | ||
* // whether to bundle JS and assets in release mode | ||
* bundleInRelease: true, | ||
* | ||
* // whether to bundle JS and assets in another build variant (if configured). | ||
* // See http://tools.android.com/tech-docs/new-build-system/user-guide#TOC-Build-Variants | ||
* // The configuration property can be in the following formats | ||
* // 'bundleIn${productFlavor}${buildType}' | ||
* // 'bundleIn${buildType}' | ||
* // bundleInFreeDebug: true, | ||
* // bundleInPaidRelease: true, | ||
* // bundleInBeta: true, | ||
* | ||
* // the root of your project, i.e. where "package.json" lives | ||
* root: "../../", | ||
* | ||
* // where to put the JS bundle asset in debug mode | ||
* jsBundleDirDebug: "$buildDir/intermediates/assets/debug", | ||
* | ||
* // where to put the JS bundle asset in release mode | ||
* jsBundleDirRelease: "$buildDir/intermediates/assets/release", | ||
* | ||
* // where to put drawable resources / React Native assets, e.g. the ones you use via | ||
* // require('./image.png')), in debug mode | ||
* resourcesDirDebug: "$buildDir/intermediates/res/merged/debug", | ||
* | ||
* // where to put drawable resources / React Native assets, e.g. the ones you use via | ||
* // require('./image.png')), in release mode | ||
* resourcesDirRelease: "$buildDir/intermediates/res/merged/release", | ||
* | ||
* // by default the gradle tasks are skipped if none of the JS files or assets change; this means | ||
* // that we don't look at files in android/ or ios/ to determine whether the tasks are up to | ||
* // date; if you have any other folders that you want to ignore for performance reasons (gradle | ||
* // indexes the entire tree), add them here. Alternatively, if you have JS files in android/ | ||
* // for example, you might want to remove it from here. | ||
* inputExcludes: ["android/**", "ios/**"], | ||
* | ||
* // override which node gets called and with what additional arguments | ||
* nodeExecutableAndArgs: ["node"] | ||
* | ||
* // supply additional arguments to the packager | ||
* extraPackagerArgs: [] | ||
* ] | ||
*/ | ||
|
||
project.ext.react = [ | ||
// the name of the generated asset file containing your JS bundle | ||
bundleAssetName: "index.bundle", | ||
|
||
// the entry file for bundle generation | ||
entryFile: "index.js", | ||
] | ||
|
||
apply from: "../../../node_modules/react-native/react.gradle" | ||
|
||
/** | ||
* Set this to true to create two separate APKs instead of one: | ||
* - An APK that only works on ARM devices | ||
* - An APK that only works on x86 devices | ||
* The advantage is the size of the APK is reduced by about 4MB. | ||
* Upload all the APKs to the Play Store and people will download | ||
* the correct one based on the CPU architecture of their device. | ||
*/ | ||
def enableSeparateBuildPerCPUArchitecture = false | ||
|
||
/** | ||
* Run Proguard to shrink the Java bytecode in release builds. | ||
*/ | ||
def enableProguardInReleaseBuilds = false | ||
|
||
android { | ||
compileSdkVersion 23 | ||
buildToolsVersion "23.0.1" | ||
|
||
defaultConfig { | ||
applicationId "com.happo" | ||
minSdkVersion 16 | ||
targetSdkVersion 22 | ||
versionCode 1 | ||
versionName "1.0" | ||
ndk { | ||
abiFilters "armeabi-v7a", "x86" | ||
} | ||
} | ||
splits { | ||
abi { | ||
reset() | ||
enable enableSeparateBuildPerCPUArchitecture | ||
universalApk false // If true, also generate a universal APK | ||
include "armeabi-v7a", "x86" | ||
} | ||
} | ||
buildTypes { | ||
release { | ||
minifyEnabled enableProguardInReleaseBuilds | ||
proguardFiles getDefaultProguardFile("proguard-android.txt"), "proguard-rules.pro" | ||
} | ||
} | ||
// applicationVariants are e.g. debug, release | ||
applicationVariants.all { variant -> | ||
variant.outputs.each { output -> | ||
// For each separate APK per architecture, set a unique version code as described here: | ||
// http://tools.android.com/tech-docs/new-build-system/user-guide/apk-splits | ||
def versionCodes = ["armeabi-v7a":1, "x86":2] | ||
def abi = output.getFilter(OutputFile.ABI) | ||
if (abi != null) { // null for the universal-debug, universal-release variants | ||
output.versionCodeOverride = | ||
versionCodes.get(abi) * 1048576 + defaultConfig.versionCode | ||
} | ||
} | ||
} | ||
} | ||
|
||
dependencies { | ||
compile project(':react-native-view-shot') | ||
compile fileTree(dir: "libs", include: ["*.jar"]) | ||
compile "com.android.support:appcompat-v7:23.0.1" | ||
compile "com.facebook.react:react-native:+" // From node_modules | ||
} | ||
|
||
// Run this once to be able to run the application with BUCK | ||
// puts all compile dependencies into folder libs for BUCK to use | ||
task copyDownloadableDepsToLibs(type: Copy) { | ||
from configurations.compile | ||
into 'libs' | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,66 @@ | ||
# Add project specific ProGuard rules here. | ||
# By default, the flags in this file are appended to flags specified | ||
# in /usr/local/Cellar/android-sdk/24.3.3/tools/proguard/proguard-android.txt | ||
# You can edit the include path and order by changing the proguardFiles | ||
# directive in build.gradle. | ||
# | ||
# For more details, see | ||
# http://developer.android.com/guide/developing/tools/proguard.html | ||
|
||
# Add any project specific keep options here: | ||
|
||
# If your project uses WebView with JS, uncomment the following | ||
# and specify the fully qualified class name to the JavaScript interface | ||
# class: | ||
#-keepclassmembers class fqcn.of.javascript.interface.for.webview { | ||
# public *; | ||
#} | ||
|
||
# Disabling obfuscation is useful if you collect stack traces from production crashes | ||
# (unless you are using a system that supports de-obfuscate the stack traces). | ||
-dontobfuscate | ||
|
||
# React Native | ||
|
||
# Keep our interfaces so they can be used by other ProGuard rules. | ||
# See http://sourceforge.net/p/proguard/bugs/466/ | ||
-keep,allowobfuscation @interface com.facebook.proguard.annotations.DoNotStrip | ||
-keep,allowobfuscation @interface com.facebook.proguard.annotations.KeepGettersAndSetters | ||
-keep,allowobfuscation @interface com.facebook.common.internal.DoNotStrip | ||
|
||
# Do not strip any method/class that is annotated with @DoNotStrip | ||
-keep @com.facebook.proguard.annotations.DoNotStrip class * | ||
-keep @com.facebook.common.internal.DoNotStrip class * | ||
-keepclassmembers class * { | ||
@com.facebook.proguard.annotations.DoNotStrip *; | ||
@com.facebook.common.internal.DoNotStrip *; | ||
} | ||
|
||
-keepclassmembers @com.facebook.proguard.annotations.KeepGettersAndSetters class * { | ||
void set*(***); | ||
*** get*(); | ||
} | ||
|
||
-keep class * extends com.facebook.react.bridge.JavaScriptModule { *; } | ||
-keep class * extends com.facebook.react.bridge.NativeModule { *; } | ||
-keepclassmembers,includedescriptorclasses class * { native <methods>; } | ||
-keepclassmembers class * { @com.facebook.react.uimanager.UIProp <fields>; } | ||
-keepclassmembers class * { @com.facebook.react.uimanager.annotations.ReactProp <methods>; } | ||
-keepclassmembers class * { @com.facebook.react.uimanager.annotations.ReactPropGroup <methods>; } | ||
|
||
-dontwarn com.facebook.react.** | ||
|
||
# okhttp | ||
|
||
-keepattributes Signature | ||
-keepattributes *Annotation* | ||
-keep class okhttp3.** { *; } | ||
-keep interface okhttp3.** { *; } | ||
-dontwarn okhttp3.** | ||
|
||
# okio | ||
|
||
-keep class sun.misc.Unsafe { *; } | ||
-dontwarn java.nio.file.* | ||
-dontwarn org.codehaus.mojo.animal_sniffer.IgnoreJRERequirement | ||
-dontwarn okio.** |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
<manifest xmlns:android="http://schemas.android.com/apk/res/android" | ||
package="com.happo" | ||
android:versionCode="1" | ||
android:versionName="1.0"> | ||
|
||
<uses-permission android:name="android.permission.INTERNET" /> | ||
<uses-permission android:name="android.permission.SYSTEM_ALERT_WINDOW"/> | ||
|
||
<uses-sdk | ||
android:minSdkVersion="16" | ||
android:targetSdkVersion="22" /> | ||
|
||
<application | ||
android:name=".MainApplication" | ||
android:allowBackup="true" | ||
android:label="@string/app_name" | ||
android:icon="@mipmap/ic_launcher" | ||
android:theme="@style/AppTheme"> | ||
<activity | ||
android:name=".MainActivity" | ||
android:label="@string/app_name" | ||
android:configChanges="keyboard|keyboardHidden|orientation|screenSize"> | ||
<intent-filter> | ||
<action android:name="android.intent.action.MAIN" /> | ||
<category android:name="android.intent.category.LAUNCHER" /> | ||
</intent-filter> | ||
</activity> | ||
<activity android:name="com.facebook.react.devsupport.DevSettingsActivity" /> | ||
</application> | ||
|
||
</manifest> |
15 changes: 15 additions & 0 deletions
15
native/android/app/src/main/java/com/snapshot_demo/MainActivity.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
package com.happo; | ||
|
||
import com.facebook.react.ReactActivity; | ||
|
||
public class MainActivity extends ReactActivity { | ||
|
||
/** | ||
* Returns the name of the main component registered from JavaScript. | ||
* This is used to schedule rendering of the component. | ||
*/ | ||
@Override | ||
protected String getMainComponentName() { | ||
return "happo_snapshots"; | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already have this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol this list is long 🚋