Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reintroduce some ESlint rules #608

Closed
mikabytes opened this issue Jan 24, 2024 · 0 comments
Closed

Reintroduce some ESlint rules #608

mikabytes opened this issue Jan 24, 2024 · 0 comments
Assignees
@lencioni

Comments

@mikabytes
Copy link
Collaborator

  • no-unused-vars
  • no useless returns

... probably several others.

These were removed as part of #598
lencioni added a commit that referenced this issue Jun 7, 2024
@lencioni
Remove flow type annotations
0e5eeb5 
We know that we do not want to use flow anymore. We may want to adopt
TypeScript, but it is unclear if we will in the near term.

#593

I want to re-introduce ESLint, and instead of setting up ESLint to be
able to parse flow syntax, I decided that we should just remove it.

#608

I removed these annotations by running the following command:

```
npx flow-remove-types lib/ -d lib/
```

Then I formatted the files by running prettier on everything:

```
node_modules/.bin/prettier -w lib/
```

I think if we wanted to introduce TypeScript that it might be easier to
do it from scratch anyway instead of attempting to convert the flow
types over to a different type system.
@lencioni lencioni mentioned this issue Jun 7, 2024
Merged
@mikabytes mikabytes mentioned this issue Jun 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lencioni lencioni

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lencioni @mikabytes