Improve some error reporting #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was trying out import-js in a project that has an .eslintrc.js file that extends an eslint config package installed by npm. When running auto import in this project, it was simply just not doing anything, which was perplexing because I could see eslint reporting undefined variables that import-js could resolve. After some digging, I discovered that this was because eslint was outputting errors like: > Cannot read config package: eslint-config-airbnb This commit doesn't resolve the problem I was encountering, but it at least makes it easier to understand what is going on. After knowing this, I was able to resolve my problem by installing the missing eslint config package globally.
I was trying out import-js in a project that has an .eslintrc.js file that relies on an eslint plugin installed by npm. When running auto import in this project, it was simply just not doing anything, which was perplexing because I could see eslint reporting undefined variables that import-js could resolve. After some digging, I discovered that this was because eslint was outputting errors like: > Cannot find module 'eslint-plugin-react' This commit doesn't resolve the problem I was encountering, but it at least makes it easier to understand what is going on. After knowing this, I was able to resolve my problem by installing the missing eslint plugin package globally.
I was trying out import-js in a project that has an .eslintrc.js file that relies on a parser installed by npm. When running auto import in this project, it was simply just not doing anything, which was perplexing because I could see eslint reporting undefined variables that import-js could resolve. After some digging, I discovered that this was because eslint was outputting errors to stdout like: > <text>:0:0: Cannot find module 'babel-eslint' This commit doesn't resolve the problem I was encountering, but it at least makes it easier to understand what is going on. After knowing this, I was able to resolve my problem by installing the missing eslint parser package globally.
|
I'm not sure under what circumstances eslint will output to stderr, but it might not be a bad idea to bubble stderr up to the editor in every case. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.