Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to use .importjs-root file to detect project root #547

Merged
merged 2 commits into from
Dec 9, 2019

Conversation

mikabytes
Copy link
Collaborator

@mikabytes mikabytes commented Dec 5, 2019

As discussed in #546

This adds the option to create a file .importjs-root to allow for ImportJS to detect the root of the project.

This is useful for projects that don't have a package.json, such as those that use native ES modules only.

@mikabytes
Copy link
Collaborator Author

Hm, could someone help me understand what's going on with Travis? Those errors seem unrelated to my changes, and all tests pass when I run them locally.

@trotzig
Copy link
Collaborator

trotzig commented Dec 5, 2019

Looks like failures are coming from Node v6&7. Are you able to repro locally with one of those versions? If not I think it’s safe to cut out Node < 8 (I can make that happen as part of releasing this change).

@trotzig
Copy link
Collaborator

trotzig commented Dec 5, 2019

Btw, thanks for making a PR! Quick turnaround! 👏

@mikabytes
Copy link
Collaborator Author

mikabytes commented Dec 9, 2019

Happy to contribute to such an awesome tool. One of the few I use every hour of the day ;)

I have confirmed this is an issue with Node 7 (probably also holds true for 6). Also confirmed the same test results in master branch, so this is not related to this PR.

Always happy to drop support. You have my encouragement :)

@trotzig trotzig merged commit c93ce12 into Galooshi:master Dec 9, 2019
@trotzig
Copy link
Collaborator

trotzig commented Dec 9, 2019

After some CI/build issues I was finally able to get a release shipped. This change is included in v4. 🚢

@trotzig
Copy link
Collaborator

trotzig commented Dec 9, 2019

What editor are you using? I'm a vim user myself, but I made sure to bump the Atom plugin as well (which is the only plugin with a direct dependency on the import-js npm lin--others rely on a globally installed command).

@mikabytes
Copy link
Collaborator Author

Awesomeness! Quick turnaround indeed.

I'm a devout Vim user, and although I don't like to bloat my editor with YouCompleteMe and such, ImportJS is really bringing that warm breeze into my work environment. Especially when working with libs that require lots of small little imports; Redux Saga, Yup, etc.

Ha en fin vinterdag! Snart läggdags här i Filippinerna ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants