Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate if skipProbe is needed for other virtual channel scenarios #1506

Open
vindard opened this issue Aug 2, 2022 · 6 comments
Open

Comments

@vindard
Copy link
Contributor

vindard commented Aug 2, 2022

Description

We recently implemented a skip probe pathway (#1505) for instances like payments to Muun where the probe would always fail since the last hop doesn't exist, but mission control also fails any actual payments sent soon after this.

This issue is to investigate other instances where this could potentially happen. Mostly it's for services that:

  • create channels on the fly (e.g. Breez, Phoenix) for:

    • brand new users
    • users that don't have enough existing receive capacity
  • use other schemes like hosted channels (e.g. SBW)

Related issues:

@nicolasburtey
Copy link
Member

related to #32

@openoms
Copy link
Collaborator

openoms commented Aug 13, 2022

Just testing hosted channels for CLN with poncho (raspiblitz/raspiblitz#3269). I expect this solution getting more popular.

The probe failes when trying to pay an invoice (with a route hint) to a hosted channel, but can be paid directly with LND.

Options:

  • skip probing if the last hop is advertising hosted channels (with the feature bit) - complicated to implement.
  • skip probing for all invoices containing route hints - quick, but has false positives.

@nicolasburtey
Copy link
Member

@openoms adding the node in question to the list of skip probe peers doesn't work?

@openoms
Copy link
Collaborator

openoms commented Aug 13, 2022

@openoms adding the node in question to the list of skip probe peers doesn't work?

It wouldn't be an effective solution since now any CLN and already any Eclair node can support hosted channels, they just need to start a plugin. Find some long running examples on the end of this article https://sbw.app/posts/scaling-ln-with-hosted-channels/ and for the sake of experimentation I just created two more in a few minutes.

Hosted channels are also a great way the use the liquidity of an own node remotely on mobile - so could as popular even just for private usage as using Zeus.

Also outside contributors are already planning to implement it for LND.

@openoms
Copy link
Collaborator

openoms commented Aug 30, 2022

Update: poncho v0.2.0 is out and managed to pay successfully to a hosted channel with BBW. The fee was grossly overestimated, but the difference was returned.

So don't need to skip nodes offering hosted channels!

@nicolasburtey
Copy link
Member

Probably the solution:

lightningnetwork/lnd#6910

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants