Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent infinite 401 loop #2109

Merged
merged 1 commit into from Apr 26, 2023
Merged

fix: prevent infinite 401 loop #2109

merged 1 commit into from Apr 26, 2023

Conversation

UncleSamtoshi
Copy link
Collaborator

@UncleSamtoshi UncleSamtoshi commented Apr 26, 2023

  • reverts 401 modal changes and instead gives special retry mechanism for 401 errors before logging the user out
  • reorder retryLink so that it runs before the errorLink, in the past we set the error before we even retried, this should retry first and then if it still fails it will set the network error (it should help with the 502 errors we are seeing)

Copy link
Member

@nicolasburtey nicolasburtey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some questions on the code. I haven't tried locally yet

Copy link
Member

@nicolasburtey nicolasburtey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haven't tried locally but logic sounds good. I think that's a good/better compromise.

@UncleSamtoshi UncleSamtoshi merged commit 5849991 into main Apr 26, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants