chore: add unique id to write-sdl bin script #4169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue here is that on first creation 'public-sdl'/'admin-sdl' detects that there was a change in ':write-sdl' and correctly executes. On subsequent builds though, the output from ':write-sdl' does not change and so 'public-sdl' or 'admin-sdl' does not re-execute. This fix adds a unique uuid to the output script of ':write-sdl' to signal that it was re-executed and that there was some build change in one of its dependencies.
dolcalmi
previously approved these changes
Mar 11, 2024
vindard
force-pushed
the
fix-update-schemas-rerunnability
branch
from
1b5541f
to
e7f1b32
Compare
vindard
force-pushed
the
fix-update-schemas-rerunnability
branch
from
e7f1b32
to
f790a54
Compare
bodymindarts
approved these changes
Mar 12, 2024
This was referenced Mar 12, 2024
This was referenced Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue here is that on first creation
public-sdl/admin-sdldetects that there was a change in:write-sdland correctly executes. On subsequent builds though, the output from:write-sdldoes not change and sopublic-sdloradmin-sdldoes not re-execute.This fix adds a unique uuid to the output script of
:write-sdlto signal that it was re-executed and that there was some build change in one of its dependencies.