Tests that proprety factories invoke host classes query and sendcmd methods
#259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test for property factories were extended to test the following: - Setter and getter work according to the expected format. - Assert that the property getter calls its host classes `query` method - Assert that the property setter calls its host classes `sendcmd` method
|
Wow you've been on a roll! I feel like I should mail you some of the cookies I made tonight instead of refreshing my |
scasagrande
reviewed
Sep 9, 2020
|
will merge in the morning |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test for property factories were extended to test the following:
querymethodsendcmdmethod
A test class is set up using a fixture.
queryandsendcmdare implemented in a simple way such that we can assert easily that they are called using mocker spies. After getting / setting values, the spies are used to assert that the call has taken place, as discussed in issue #258.