Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ch qubitekk update #64

Closed
wants to merge 13 commits into from
Closed

Ch qubitekk update #64

wants to merge 13 commits into from

Conversation

CatherineH
Copy link
Contributor

This is a clean up of the original qubitekk code, and an update to the latest version of the firmware. I have not ensured 100% test coverage.

@CatherineH
Copy link
Contributor Author

Okay, the qubitekk cc1 is at 100% coverage. This is ready to merge.

@@ -63,7 +76,7 @@ class Channel(object):
__CHANNEL_NAMES = {
1: 'C1',
2: 'C2',
3: 'C0'
3: 'CO'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does CC1.channel[2] end up mapping to C0?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, that's CO not C0

@CatherineH
Copy link
Contributor Author

I'm closing this PR because I've been adding my changes to the branch on the main fork.

@CatherineH CatherineH closed this Mar 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants