Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

:fix rooms pageNum and return format #145

Merged
merged 2 commits into from
Aug 18, 2023
Merged

:fix rooms pageNum and return format #145

merged 2 commits into from
Aug 18, 2023

Conversation

m1a2st
Copy link
Contributor

@m1a2st m1a2st commented Aug 13, 2023 •
edited by ricksu978

Why need this change? / Root cause:

  • according to frontend's request

Changes made:

  • page logic and return api format

Test Scope / Change impact:

  • RoomControllerTest

Issue

Wally5077
Wally5077 requested changes Aug 13, 2023
View reviewed changes
Copy link
Collaborator

@Wally5077 Wally5077 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review done.

spring/src/main/kotlin/tw/waterballsa/gaas/spring/controllers/RoomController.kt Outdated Show resolved Hide resolved
spring/src/main/kotlin/tw/waterballsa/gaas/spring/controllers/presenter/GetRoomsPresenter.kt Outdated Show resolved Hide resolved
spring/src/test/kotlin/tw/waterballsa/gaas/spring/it/controllers/RoomControllerTest.kt Outdated Show resolved Hide resolved
spring/src/test/kotlin/tw/waterballsa/gaas/spring/models/TestGetRoomsRequest.kt Outdated Show resolved Hide resolved
frankvicky
frankvicky requested changes Aug 14, 2023
View reviewed changes
spring/src/test/kotlin/tw/waterballsa/gaas/spring/it/controllers/RoomControllerTest.kt Outdated

givenWaitingRooms(userB, userC)
request.whenUserAVisitLobby(userA)
.andDo { println(it.response.contentAsString) }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q：印出來的目的？

Wally5077
Wally5077 requested changes Aug 17, 2023
View reviewed changes
Copy link
Collaborator

@Wally5077 Wally5077 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review done.

spring/src/main/kotlin/tw/waterballsa/gaas/spring/controllers/viewmodel/GetRoomsViewModel.kt Outdated
@@ -21,6 +21,6 @@ data class GetRoomsViewModel(
data class Page(
val total: Int,
val page: Int,
val offset: Int
val perPage: Int
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

變數名不用改，改成用上註解 ＠JsonProperty

@sonarcloud
Copy link

sonarcloud bot commented Aug 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Wally5077
Wally5077 approved these changes Aug 17, 2023
View reviewed changes
Copy link
Collaborator

@Wally5077 Wally5077 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@m1a2st m1a2st merged commit 7c4167a into main Aug 18, 2023
5 checks passed
@m1a2st m1a2st deleted the fix/get-rooms branch August 18, 2023 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wally5077 Wally5077 Wally5077 approved these changes

@frankvicky frankvicky frankvicky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GET /rooms response change offset to perPage
3 participants
@m1a2st @Wally5077 @frankvicky