Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ 新增 LogData Entity #146

Merged
merged 3 commits into from
Aug 30, 2023
Merged

✨ 新增 LogData Entity #146

merged 3 commits into from
Aug 30, 2023

Conversation

frankvicky
Copy link
Collaborator

Why need this change? / Root cause:

  • 為日誌功能做準備

Changes made:

  • LogData

Test Scope / Change impact:

  • spring module

Issue

  • none

Copy link
Collaborator

@Wally5077 Wally5077 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review done.

@ricksu978
Copy link
Member

@frankvicky @Wally5077

這個 PR 需要我的 approval 才能 merge 喔。

我晚點再來仔細看過,從需求功能面來看,有些沒有達到。

@ricksu978 ricksu978 linked an issue Aug 15, 2023 that may be closed by this pull request
@ricksu978
Copy link
Member

ricksu978 commented Aug 15, 2023

@frankvicky
詳細需求寫在 #147

新需求 4.5 / 4.6 / 5

Copy link
Collaborator

@Wally5077 Wally5077 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ricksu978 ricksu978 self-requested a review August 16, 2023 12:28
Copy link
Collaborator

@Wally5077 Wally5077 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review done.

var title: String,
@CreatedDate
val createdDate: LocalDate,
val author: String,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q:這個是「非平台用戶」也能發嗎?

@sonarcloud
Copy link

sonarcloud bot commented Aug 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@ricksu978 ricksu978 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@Wally5077 Wally5077 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@frankvicky frankvicky merged commit 5fb0eb9 into main Aug 30, 2023
5 checks passed
@frankvicky frankvicky deleted the feature/log-table-entity branch August 30, 2023 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

資料庫前置準備
3 participants