-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ 新增 LogData Entity #146
✨ 新增 LogData Entity #146
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review done.
spring/src/main/kotlin/tw/waterballsa/gaas/spring/repositories/data/LogData.kt
Outdated
Show resolved
Hide resolved
這個 PR 需要我的 approval 才能 merge 喔。 我晚點再來仔細看過,從需求功能面來看,有些沒有達到。 |
@frankvicky 新需求 4.5 / 4.6 / 5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
spring/src/main/kotlin/tw/waterballsa/gaas/spring/repositories/data/GameDevelopmentLog.kt
Show resolved
Hide resolved
0be5794
to
f179991
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review done.
spring/src/main/kotlin/tw/waterballsa/gaas/spring/repositories/data/LogCategory.kt
Show resolved
Hide resolved
var title: String, | ||
@CreatedDate | ||
val createdDate: LocalDate, | ||
val author: String, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q:這個是「非平台用戶」也能發嗎?
spring/src/main/kotlin/tw/waterballsa/gaas/spring/repositories/data/GameDevelopmentLog.kt
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Why need this change? / Root cause:
Changes made:
Test Scope / Change impact:
Issue