串接大平台1 #93
Merged
串接大平台1 #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s9891326
force-pushed
the
feature/add_lobby_start_game_api
branch
from
17dd4d6
to
a8bbd8f
Compare
2. Add create jwt function to fix jwt_token expire problem
qrtt1
reviewed
Sep 15, 2023
love_letter/config.py
Outdated
| @@ -7,3 +7,8 @@ | |||
| DB_PASSWORD = os.environ.get("DB_PASSWORD") | |||
| DB_NAME = os.environ.get("DB_NAME", "love_letter") | |||
| DB_COLLECTION = os.environ.get("DB_COLLECTION", "love_letter") | |||
| FRONTEND_HOST = os.environ.get("FRONTEND_HOST", "http://127.0.0.1") | |||
There was a problem hiding this comment.
config 的內容，把它們收納成一個 class 或一個 object instance。
這樣統一 import 一個 class 或 object 就可以用了，不會讓參數那麼「零碎」。
There was a problem hiding this comment.
喔~ 看了自己寫的FRONTEND_HOST後，好像有點懂「零碎」的意思了，指的是這樣嗎~
# 原本import方式，可以直接得到想要的參數
from love_letter.config import FRONTEND_HOST
print(FRONTEND_HOST)
# 包進class並初始化後，只能透過該object才能抓到要的參數，增加了使用config時的約束力(一定要import這個object才能使用)
from love_letter.config import config
print(config.FRONTEND_HOST)There was a problem hiding this comment.
對呦。這樣才不會需要超過 1 個以上的 import 來處理同時使用的問題
qrtt1
reviewed
Sep 15, 2023
love_letter/models/__init__.py
Outdated
| @@ -333,7 +333,8 @@ class Seen: | |||
|
|
|||
|
|
|||
| class Player: | |||
| def __init__(self, name: str): | |||
| def __init__(self, name: str, _id: Union[str] = None): | |||
There was a problem hiding this comment.
_id 似乎沒有必要，大概是為了避內建的 id 嗎？如果 lint 沒有意見，那就保留，或改成 user_id 或 account_id 或 account 之類的。
There was a problem hiding this comment.
為了避開內建的id，我改成user_id好了
qrtt1
reviewed
Sep 15, 2023
| ) | ||
| return True | ||
| except Exception as e: | ||
| print(e) |
There was a problem hiding this comment.
接近要上線的時刻，也許值得在追另新的 task，接上 sentry
https://sentry.io/welcome/
Open
qrtt1
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
先開發一部分issue內的東西