Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Removed heartbeat redundant breakpoints and tests #106

Conversation

KazeNoYumeX
Copy link
Collaborator

Why need this change? / Root cause:

The heartbeat endpoint had redundant breakpoints and tests that were not necessary for its functionality. These redundancies were causing unnecessary complexity and potential confusion in the codebase.

Changes made:

This commit removes the redundant breakpoints and tests from the heartbeat endpoint. The code has been refactored to be more streamlined and efficient, without losing any of its functionality.

Test Scope / Change impact:

The changes have been tested locally to ensure that the heartbeat endpoint still functions as expected. The impact of these changes is minimal, as they primarily involve cleaning up the codebase and do not affect the endpoint's functionality. However, the code is now easier to read and maintain, which will benefit future development efforts.

Copy link
Collaborator

@linycken013127 linycken013127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

@linycken013127 linycken013127 merged commit 5c586f3 into Game-as-a-Service:dev Jan 22, 2024
3 checks passed
@KazeNoYumeX KazeNoYumeX deleted the feature/refactor-heartbeat-test branch February 17, 2024 08:11
@linycken013127 linycken013127 mentioned this pull request Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants