-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change rendering engine to use PBR with standard pipelines #24
Conversation
This incurs an FPS penalty which brings it to ~50fps on my M1 MacBook Air. Personally, I think the shadows are substantially nice enough to make the performance hit worth it -- especially once Bevy has SSAO. |
Liquids / translucent voxels should probably be meshed separately but I find allocating a whole mesh for just translucents voxels a bit much, maybe merge them in a single mesh and use draw command magic to only draw the "opaque part" of the mesh and then draw the "transparent part" of it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking fine
Can this be merged as is or does it need further tweaking ? |
My initial attempts to tune the settings hasn't yielded any improvement to the shadow quality, so I'm happy to merge as-is and just let future engine improvements carry it. |
Re: liquids & translucent voxels, there is the concern of them having different orderings (need to sort opaque things front-to-back and translucent things back-to-front before drawing). I suspect having separate materials/meshes for them will ultimately be easier within the existing framework (they could be two children entities of the chunk, for instance) but I haven't given it much actual thought yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
… shadows!
(should probably investigate meshing water / translucent objects separately?)