Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add third-person view camera & player box #25

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

meyerzinn
Copy link
Contributor

In preparation for physics, it is useful to have an actual player model & a third-person camera to watch.

I'm not sure how physics will integrate quite yet, but I imagine it replaces the rotation slerp with an angular acceleration.

@meyerzinn
Copy link
Contributor Author

meyerzinn commented May 4, 2023

Another consideration for physics: It's a bit weird to have translation on the Player entity but rotation on Body. We could get around this pretty easily by using a cylinder for collision detection instead of an AABB, which makes it rotation-independent.

@Game4all
Copy link
Owner

Is this good to go as is ? @meyerzinn

Copy link
Owner

@Game4all Game4all left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apart from a nit, looks good to me.

src/voxel/world/chunks.rs Outdated Show resolved Hide resolved
@meyerzinn
Copy link
Contributor Author

meyerzinn commented May 17, 2023

@Game4all should be good to go if you approve of the refactors.

@meyerzinn
Copy link
Contributor Author

Actually, give me a little bit to try and flatten the entity tree and make the integration of physics more obvious/ergonomic.

@Game4all
Copy link
Owner

Game4all commented Jun 7, 2023

@meyerzinn still need a bit of time? (apologies for the ping)

@meyerzinn
Copy link
Contributor Author

@Game4all no worries, sorry for the delay -- my internship started and I'm working full-time this summer, so I might not have a chance to finish this up. I was working on collision detection in https://github.com/meyerzinn/vx_bevy/tree/collisions2 but didn't quite have time to hammer out the bugs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants