Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Handle leaks, incorrect translations being used, and two things. #7

Merged
merged 4 commits into from
Jul 17, 2013
Merged

Fix Handle leaks, incorrect translations being used, and two things. #7

merged 4 commits into from
Jul 17, 2013

Conversation

KyleSanderson
Copy link
Contributor

Besides the leaks and translations, the other two are just things. You're totally welcome to cherry pick commits, I don't mind. It looks like there's a lot more things that can be done, I can continue onwards if it's wanted.

There's one gotcha, this requires SM1.5 due to the param change with GetClientAuthString (which would just be garbage otherwise).

@peace-maker
Copy link
Member

Why would you disable steamid validation in the first place? I'd think especially concerning banning, one should make sure to have the correct id.

@KyleSanderson
Copy link
Contributor Author

The goal wasn't to change any actual logic, rather fix bugs. I could change the logic, add a translation string (if one doesn't already exist), and return failure if the client isn't authorized. However, I wasn't sure how it would be received, which is why I tried to only do minimal changes.

As it stands, sAuth is garbage (the target name) if GetClientAuthString returns false, which doesn't seem too great as there doesn't appear to be any sort of logic checking for valid input anywhere. I'd like to fix this, but it's quite the task, and I don't know how it would be received.

ErikMinekus added a commit that referenced this pull request Jul 17, 2013
Fix Handle leaks, incorrect translations being used, and two things.
@ErikMinekus ErikMinekus merged commit 300c3a8 into GameConnect:master Jul 17, 2013
@ErikMinekus
Copy link
Member

The sm_addban command is just plain wrong, it doesn't need to check if the client is in-game, that's what sm_ban is for. I'll rewrite it like http://hg.alliedmods.net/sourcemod-central/file/tip/plugins/basebans.sp#l204. But thanks, more help is always appreciated!

@ghost ghost mentioned this pull request Mar 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants