More fixes, add sanity checks to user input, prevent mismatched targets. #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Utilize StripQuotes native instead of relying on handrolled strlen hackery. Skip first character to avoid trigger dependency. Avoid processing anything if no args are passed.
See Commit b90005a for details.
There were a few bugs that were fixed with this refactoring as well, mainly IsClientInGame erroring out when the index is 0. The main bug that was fixed is a client makes a query against a target, the target disconnects, and you're getting messages back from a potentially different target. This along with the client themselves disconnecting, someone else joins, and then they get the output of the command. There may be some definite fallout from this, it was mostly manual labour.
This reverts commit ab1e030.
This should fix a few native errors, and ultimately act as a more stable method of protecting client data/sanity. Targets (issuers) can change during the query delay, along with many other things. It's definitely not something that's good, which is what this commit is attempting to change.
|
Merged manually and changed some things, but overall great fixes. Next time I'll merge first and change it afterwards, since that's probably less error-prone, but it looks like it went fine. Thanks again! |
ghost
mentioned this pull request
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There may be some definite fallout from commit ab1e030 . The rest however is fairly straight forward. Again, totally welcome to cherry pick whatever you wish, hopefully it's all for the better 🎱