Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Fix] Global Shortcut fix for MacOs #12

Merged
merged 2 commits into from Oct 2, 2021
Merged

[Bug Fix] Global Shortcut fix for MacOs #12

merged 2 commits into from Oct 2, 2021

Conversation

AJAYK-01
Copy link
Contributor

@AJAYK-01 AJAYK-01 commented Oct 2, 2021

Context

  • The existing shortcut Shift + Caps Lock works on Windows and Linux, but not on MacOs because Caps Lock is considered a modifier key on the MacOs platform but not on Windows and Linux.
  • Keyboard Shortcuts need to be of the form Modifier Key/Keys + Final Key on any platform.

Changes Made

  • Switched to Shift + Tab as a shortcut specifically for MacOs keeping the Windows and Linux shortcuts unchanged.
  • Updated Readme to mention the MacOs shortcut.

@AJAYK-01 AJAYK-01 changed the title Global Shortcut fix for MacOs [Bug Fix] Global Shortcut fix for MacOs Oct 2, 2021
@GameGodS3 GameGodS3 marked this pull request as ready for review October 2, 2021 08:10
@GameGodS3 GameGodS3 added the bug Something isn't working label Oct 2, 2021
@GameGodS3
Copy link
Owner

Thank you 😊

@GameGodS3 GameGodS3 merged commit 9ff7355 into GameGodS3:main Oct 2, 2021
@GameGodS3 GameGodS3 added the hacktoberfest-accepted Your PR is valid and has been qualified for hacktoberfest label Oct 2, 2021
@AJAYK-01 AJAYK-01 deleted the shortcut-fix-macos branch October 2, 2021 09:44
@GameGodS3 GameGodS3 added the macos label Oct 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working hacktoberfest-accepted Your PR is valid and has been qualified for hacktoberfest macos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AJAYK-01 @GameGodS3