Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Fix]: Fix remove window buttons on MacOs #16

Merged
merged 1 commit into from Oct 9, 2021

Conversation

AJAYK-01
Copy link
Contributor

@AJAYK-01 AJAYK-01 commented Oct 9, 2021

Context

On MacOs just setting frame: false didn't seem to remove the OS's native title bar window buttons like in Windows and Linux.
2021-10-09_22 32 32

Description of the Change

This PR adds a small change and adds setWindowButtonVisibility(false); parameter which seems to fix the issue on MacOs.

Possible Drawbacks

This change has not been tested on Windows and Linux.

Verification Process

Tested on MacOs and Confirmed the change fixes the issue.

Screenshot 2021-10-09 at 10 35 18 PM

Release Notes

Fixed an Issue where the OS native Window buttons persisted on MacOs.

@AJAYK-01 AJAYK-01 changed the title Fix remove window buttons on MacOs [Bug Fix]: Fix remove window buttons on MacOs Oct 9, 2021
@GameGodS3 GameGodS3 added bug Something isn't working hacktoberfest-accepted Your PR is valid and has been qualified for hacktoberfest macos labels Oct 9, 2021
@GameGodS3
Copy link
Owner

Thank You!
Merging

@GameGodS3 GameGodS3 merged commit 1554d2b into GameGodS3:main Oct 9, 2021
@AJAYK-01 AJAYK-01 deleted the window-button-fix branch October 10, 2021 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hacktoberfest-accepted Your PR is valid and has been qualified for hacktoberfest macos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants