Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible concurrency issues with Minecraft packet handling. #1

Open
Gliby opened this issue Dec 30, 2016 · 1 comment
Open

Possible concurrency issues with Minecraft packet handling. #1

Gliby opened this issue Dec 30, 2016 · 1 comment

Comments

@Gliby
Copy link
Collaborator

Gliby commented Dec 30, 2016

https://github.com/GameModsBR/VoiceChat/tree/master/src/main/java/net/gliby/voicechat/common/networking/packets
The issue is with the onMesssage code, If I recall correctly this function gets called on the network thread, possible concurrency issue, as well as stressing the network thread. A simple fix would be to schedule the code inside the function, so it would execute on the main Minecraft thread.
I'll be reporting issues with my own code, if anyone wants to fix 'em.

@Gliby
Copy link
Collaborator Author

Gliby commented Jan 2, 2017

Gliby pushed a commit that referenced this issue Feb 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant