Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Var extip in info_distro.sh never gets populated? #2056

Closed
Bourne-ID opened this issue Oct 23, 2018 · 3 comments
Closed

Var extip in info_distro.sh never gets populated? #2056

Bourne-ID opened this issue Oct 23, 2018 · 3 comments
Labels
outcome: issue resolved This issue was resolved type: bug Something isn't working
Milestone

Comments

@Bourne-ID
Copy link
Contributor

Code in question: https://github.com/GameServerManagers/LinuxGSM/blob/master/lgsm/functions/info_distro.sh#L165-L174

The cURL command appears to be incorrect as the variable extip is always going to be null - the command is directing the cURL output to file and any errors to /dev/null. Likewise if the command exit code is a failure code then it either echos the file location, or x.x.x.x if the file doesn't exist.

This doesn't seem correct given the variable usage, but I'm struggling to understand why a temporary file was used. Is there something I'm missing, or can the use of a temporary file be removed and the error handling of the command made more descriptive?

(Thanks to Coldster#4940 which pointed out the oddity)

Thanks,

@dgibbs64
Copy link
Member

dgibbs64 commented Nov 1, 2018

I remember the txt file being created to reduce the queries to ifconfig.co as there is a rate limit. But yeah I doesnt look right. the code will need to be reviewed

@dgibbs64 dgibbs64 added the type: bug Something isn't working label Nov 1, 2018
@triage-new-issues triage-new-issues bot removed the triage label Nov 1, 2018
@dgibbs64 dgibbs64 added this to the Next Release milestone Nov 1, 2018
@dgibbs64
Copy link
Member

1127c0b

@dgibbs64 dgibbs64 added the outcome: issue resolved This issue was resolved label Nov 23, 2018
@lock
Copy link

lock bot commented Nov 23, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Nov 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outcome: issue resolved This issue was resolved type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants