Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(newserver): Onset #2682

Merged
merged 16 commits into from Mar 6, 2020
Merged

Conversation

@frederic2ec
Copy link
Contributor

frederic2ec commented Feb 4, 2020

Description

Add new game Onset
Fixes #2655

Type of change

  • Bug fix (change which fixes an issue).
  • New feature (change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This pull request Subject follows the Conventional Commits standard.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have checked that this code is commented where required.
  • I have provided a detailed enough description of this PR.
  • I have checked If documentation needs updating.

Provide Github Email

Fill out below info or tick box below:

Co-authored-by: Frédéric C. <frederic.c@gemst1.io>

  • I do not wish to provide an email. I am aware this will hide me as the author of this commit.
    All pull requests will now be squashed to create a tidy commit history and simplify changelog creation. You can provide either your own email or a GitHub-provided no-reply email.

When a PR is squashed the author becomes the person who squashed the PR. This removes you as the author of your own PR.
The only workaround for this is to add your details as a co-author. More info about co-authors can be found here.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

Thank you for your Pull Request!

dgibbs64 and others added 10 commits Dec 4, 2019
@pull-assistant

This comment has been minimized.

Copy link

pull-assistant bot commented Feb 4, 2020

Score: 0.96

Best reviewed: commit by commit


Optimal code review plan

     Merge branch 'hotfix/v19.12.5'

     release v19.12.5

     First commit to test onset

     Added appid

     Fix

     updat4e info

     Added centos dependencies

     Fix onset on centos

     Tiny fix

     Tiny fix

     Added glibc

     Update core_functions.sh

     Update _default.cfg

     bypass onset startup script

     moved fix to run on start

     Merge branch 'develop' into feature/onset

Powered by Pull Assistant. Last update c1a6410 ... 1f51796. Read the comment docs.

@frederic2ec frederic2ec changed the base branch from master to develop Feb 4, 2020
@frederic2ec frederic2ec force-pushed the frederic2ec:feature/onset branch from 7cca963 to e0eb75f Feb 4, 2020
@frederic2ec frederic2ec marked this pull request as ready for review Feb 4, 2020
lgsm/functions/core_functions.sh Show resolved Hide resolved
linuxgsm.sh Outdated Show resolved Hide resolved
frederic2ec and others added 5 commits Feb 12, 2020
@dgibbs64 dgibbs64 merged commit 8bc25e1 into GameServerManagers:develop Mar 6, 2020
2 of 4 checks passed
2 of 4 checks passed
Travis CI - Pull Request Build Errored
Details
Codacy/PR Quality Review Hang in there, Codacy is reviewing your Pull request.
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
@frederic2ec frederic2ec deleted the frederic2ec:feature/onset branch Mar 8, 2020
@dgibbs64 dgibbs64 added this to the v20.1.0 milestone Mar 9, 2020
@conventional-release-bot conventional-release-bot bot mentioned this pull request Mar 13, 2020
0 of 13 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.