Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(new server): Battlefield: Vietnam #2909

Merged
merged 20 commits into from Jun 17, 2020
Merged

feat(new server): Battlefield: Vietnam #2909

merged 20 commits into from Jun 17, 2020

Conversation

ttocszed00
Copy link
Contributor

@ttocszed00 ttocszed00 commented May 29, 2020

Description

Added server support for Battlefield: Vietnam

in the server files provided here: http://linuxgsm.download/BattlefieldVietnam/
recommend deleting the serversettings.con (mods\bfvietnam\settings\serversettings.con) that is inside so the install config function works to pull the default config from the config repo. or could be implemented in a fix.

I don't have a Centos setup yet to verify the depends.

Fixes #2691

Type of change

  • Bug fix (a change which fixes an issue).
  • New feature (change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This pull request Subject follows the Conventional Commits standard.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • I have checked that this code is commented where required.
  • I have provided a detailed with enough description of this PR.
  • I have checked If documentation needs updating.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

Thank you for your Pull Request!

@dgibbs64 dgibbs64 added the type: game server request Request for a new server label Jun 17, 2020
@dgibbs64 dgibbs64 added this to the v20.4.0 milestone Jun 17, 2020
@dgibbs64 dgibbs64 merged commit f2f8063 into GameServerManagers:develop Jun 17, 2020
@dgibbs64 dgibbs64 linked an issue Jul 13, 2020 that may be closed by this pull request
4 tasks
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: game server request Request for a new server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Server Request] Battlefield Vietnam
2 participants