Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mods): add rust carbon mod #4122

Merged
merged 3 commits into from
Mar 26, 2023
Merged

feat(mods): add rust carbon mod #4122

merged 3 commits into from
Mar 26, 2023

Conversation

dgibbs64
Copy link
Member

@dgibbs64 dgibbs64 commented Feb 23, 2023

Description

Add support for carbon mod

Fixes #4121

Type of change

  • Bug fix (a change which fixes an issue).
  • New feature (a change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This pull request subject follows the Conventional Commits standard.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • I have checked that this code is commented where required.
  • I have provided a detailed enough description of this PR.
  • I have checked if documentation needs updating.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

Thank you for your Pull Request!

@dgibbs64 dgibbs64 added this to the v23.2.0 milestone Feb 23, 2023
@dgibbs64 dgibbs64 linked an issue Feb 23, 2023 that may be closed by this pull request
@h3o66
Copy link
Member

h3o66 commented Mar 1, 2023

As written in the Carbonmod support forum post:

I would enable the following if it is installed via lgsm

preexecutable='LD_PRELOAD="libdoorstop.so"'
export DOORSTOP_ENABLED=1
export DOORSTOP_TARGET_ASSEMBLY="${serverfiles}/carbon/managed/Carbon.Preloader.dll"

corrected with the new assembly lib

@dgibbs64
Copy link
Member Author

dgibbs64 commented Mar 1, 2023

environment.sh does this and is triggered if it exists

@h3o66
Copy link
Member

h3o66 commented Mar 1, 2023

the difference is that all executeables preload now this lib for all executeables at the start.

another point:
probably the production tag would be better instead of the latest release as well:
https://github.com/CarbonCommunity/Carbon.Core/releases/tag/production_build

the direct download here should be probably enough:
https://github.com/CarbonCommunity/Carbon.Core/releases/download/production_build/Carbon.Linux.Release.tar.gz

@jbrazio
Copy link

jbrazio commented Mar 16, 2023

I'm a core developer of Carbon.

For long term maintenance reasons I think it's better to source the environment.sh (as it is already done by this PR) instead of issuing all the environment preparation commands on the linuxgsm script itself.

We also recommend using the production_build tag as this is the most stable channel.
This PR needs to update the archive name to Carbon.Linux.Release.tar.gz.

@dgibbs64 when should we expect for the PR to be merged ? Thanks.
If you need any support don't hesitate to contact us.

@dgibbs64
Copy link
Member Author

If the only update is the name change I can get it merged very soon. Carbon is planned for the next release.

@dgibbs64
Copy link
Member Author

@jbrazio can you give this anther look and I will approve the merge if happy :)

@jbrazio
Copy link

jbrazio commented Mar 19, 2023

@dgibbs64 Just to be sure all is fine what is the easiest way to test the version from this PR locally on my system ?

@dgibbs64
Copy link
Member Author

you can edit rustserver on this line https://github.com/GameServerManagers/LinuxGSM/blob/master/linuxgsm.sh#L52 to use the branch instead and run ./rustserver ul

@jbrazio
Copy link

jbrazio commented Mar 22, 2023

@dgibbs64 As soon as I run ./rustserver mods-install I get the following error parse error: Invalid numeric literal at line 2, column 0. The mod is not working I think it's because you are executing the environment script instead of sourcing it. I left a comment on the code.

@dgibbs64
Copy link
Member Author

whats the easiest way to confirm carbon is working?

@jbrazio
Copy link

jbrazio commented Mar 23, 2023

You need to launch it attached to the console (debug) because this happens very early on the boot process. But if carbon is loaded there is an ascii banner showing. You can also check the folder carbon/logs and find three files there: Preloader, Bootstrap and Core.

@oddbunchmedia
Copy link

@dgibbs64 - in case you're not aware, the parse error: Invalid numeric literal at line 2, column 0 is present in the current prod version of LGSM too.

@jbrazio
Copy link

jbrazio commented Mar 26, 2023

CarbonCommunity/Carbon@20ff577
@dgibbs64 with this commit things should work much better. Like I said prev, instead of executing the file just source it and all will work fine, before some verbose output of the injector was messing with the stdin and breaking stuff in LinuxGSM.

@dgibbs64
Copy link
Member Author

Thanks. I will try it out now as I was having difficulty when testing.

@dgibbs64
Copy link
Member Author

I am now happy this is working

@dgibbs64 dgibbs64 merged commit 7c818be into develop Mar 26, 2023
@dgibbs64 dgibbs64 deleted the feature/rust-carbon branch March 26, 2023 22:16
@BloodyMikey
Copy link

Is it possible to select the different releases and builds?.
Production
Development
Commit
Staging.

dgibbs64 added a commit that referenced this pull request Apr 6, 2023
* feat(mods): add rust carbon

* updated tag and file name

* add source
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: add Carbon mod to mods list
5 participants