Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tiserver): fix and update to latest version #4190

Merged
merged 3 commits into from
May 16, 2023

Conversation

h3o66
Copy link
Member

@h3o66 h3o66 commented Apr 16, 2023

Description

Fixes / Additional done for "The Isle"

Adds eac launch options for server
Fixes parsing for the servername
Adds parsing for new config options

Fixes #4134

Type of change

  • Bug fix (a change which fixes an issue).
  • New feature (a change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This pull request subject follows the Conventional Commits standard.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • I have checked that this code is commented where required.
  • I have provided a detailed enough description of this PR.
  • I have checked if documentation needs updating.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

Thank you for your Pull Request!

@gitguardian
Copy link

gitguardian bot commented Apr 16, 2023

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
- Generic High Entropy Secret dbd006c lgsm/config-default/config-lgsm/tiserver/_default.cfg View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@h3o66
Copy link
Member Author

h3o66 commented Apr 16, 2023

the message from gitguardian is expected as this is needed to run the server with EAC

@h3o66 h3o66 linked an issue Apr 16, 2023 that may be closed by this pull request
@dgibbs64 dgibbs64 added this to the v23.3.0 milestone May 16, 2023
@dgibbs64 dgibbs64 merged commit ecc9934 into GameServerManagers:develop May 16, 2023
1 of 2 checks passed
@h3o66 h3o66 deleted the fix/4134-theisle branch May 16, 2023 22:06
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: The Isle currently broken
2 participants