Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve error message for unknown game server #4218

Merged
merged 1 commit into from
May 28, 2023
Merged

feat: improve error message for unknown game server #4218

merged 1 commit into from
May 28, 2023

Conversation

dgibbs64
Copy link
Member

@dgibbs64 dgibbs64 commented May 28, 2023 •
edited

Description

feat: improve error message for unknown game server

Fixes #4217

Type of change

  • Bug fix (a change which fixes an issue).
  • New feature (a change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This pull request subject follows the Conventional Commits standard.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • I have checked that this code is commented where required.
  • I have provided a detailed enough description of this PR.
  • I have checked if documentation needs updating.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

Thank you for your Pull Request!

@dgibbs64
feat: improve error message for unknown game server
4e06d4e 
The code changes modify the error message displayed when an unknown game server is entered. The new message now capitalizes the first letter of "unknown" and adds an exit status of 1 to terminate the script. This change affects multiple test files, including `tests_fctrserver.sh`, `tests_jc2server.sh`, `tests_mcserver.sh`, and `tests_ts3server.sh`.
@dgibbs64 dgibbs64 changed the title Feature/4217 linuxgsm exit code feat: improve error message for unknown game server May 28, 2023
@dgibbs64 dgibbs64 added this to the v23.4.0 milestone May 28, 2023
@dgibbs64 dgibbs64 linked an issue May 28, 2023 that may be closed by this pull request
[Bug]: Passing an invalid game string to linuxgsm.sh fails with exit code of 0 #4217
Closed
@dgibbs64 dgibbs64 changed the base branch from develop to hotfix/v23.3.2 May 28, 2023 23:04
@dgibbs64 dgibbs64 merged commit 7ddbbfd into hotfix/v23.3.2 May 28, 2023
130 of 152 checks passed
@dgibbs64 dgibbs64 deleted the feature/4217-linuxgsm-exit-code branch May 28, 2023 23:05
@dgibbs64 dgibbs64 modified the milestones: v23.4.0, v23.3.0 May 29, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 3, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v23.3.0
Development

Successfully merging this pull request may close these issues.

[Bug]: Passing an invalid game string to linuxgsm.sh fails with exit code of 0
1 participant
@dgibbs64