Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(armar): adapts game info to the new specification of server config #4240

Merged
merged 2 commits into from Jul 12, 2023

Conversation

Marcin648
Copy link
Contributor

@Marcin648 Marcin648 commented Jun 13, 2023

Description

Adapts game info to the new specification of server config.
https://community.bistudio.com/wiki/Arma_Reforger:Server_Config

Fixes #4239

Type of change

  • Bug fix (a change which fixes an issue).
  • New feature (a change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This pull request subject follows the Conventional Commits standard.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • I have checked that this code is commented where required.
  • I have provided a detailed enough description of this PR.
  • I have checked if documentation needs updating.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

Thank you for your Pull Request!

@Marcin648
Copy link
Contributor Author

Should be merged parallel with GameServerManagers/Game-Server-Configs#135

@Marcin648 Marcin648 marked this pull request as ready for review June 25, 2023 12:14
@Marcin648
Copy link
Contributor Author

I think it's ready. :)

@dgibbs64 dgibbs64 changed the base branch from develop to hotfix/v23.3.6 July 5, 2023 15:29
@dgibbs64 dgibbs64 changed the base branch from hotfix/v23.3.6 to develop July 5, 2023 15:30
@dgibbs64 dgibbs64 added this to the v23.4.0 milestone Jul 12, 2023
@dgibbs64 dgibbs64 merged commit c3d51d2 into GameServerManagers:develop Jul 12, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants