Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mcserver): change required jdk to 21 #4562

Merged

Conversation

MicLieg
Copy link
Contributor

@MicLieg MicLieg commented Apr 24, 2024

Description

As of the latest patch, minecraft now requires Java 21 to run:

The game now requires Java 21

Other distro's csv files also have to be updated.

Fixes #4564

Type of change

  • Bug fix (a change which fixes an issue).
  • New feature (a change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This pull request subject follows the Conventional Commits standard.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • I have checked that this code is commented where required.
  • I have provided a detailed enough description of this PR.
  • I have checked if documentation needs updating.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

Thank you for your Pull Request!

@dgibbs64
Copy link
Member

dgibbs64 commented May 5, 2024

This PR will need the other distros added in as well rather than needing 2 seperate PR's

@MicLieg
Copy link
Contributor Author

MicLieg commented May 5, 2024

I agree.
Unfortunately I'm not sure how to efficiently identify which distribution provides openjdk-21-jre by default. I thnik given that most users are running Ubuntu, and that the next most popular distribution, Debian, doesn't seem to include Java 21 out of the box, it's worth fixing this issue for over 60% of LGSM users right now, before wating for a fix for all the other distros.

If there's an easy way of checking wether the other distros offer Java 21, i'll happily update this PR.

@dgibbs64 dgibbs64 changed the base branch from develop to hotfix/v24.2.1 May 5, 2024 20:54
@dgibbs64
Copy link
Member

dgibbs64 commented May 5, 2024

I have sorted it as I have needed to do this before 😃

@dgibbs64 dgibbs64 added this to the v24.2.0 milestone May 5, 2024
@dgibbs64 dgibbs64 merged commit dc6cbce into GameServerManagers:hotfix/v24.2.1 May 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants