Updated to work with NIST API 2.0 #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GamehunterKaan @eric-glb @iaacornus Is this project still active? |
|
I can't tell. My contribution was really simple, and it seems it was the last one (with the README update, that may tell us he considers this project achieved?). |
GamehunterKaan
approved these changes
Feb 21, 2024
GamehunterKaan
requested changes
Feb 21, 2024
| request = get(url, params=paramaters) | ||
| data = request.json() | ||
| response = get(url, params=parameters, headers=headers) | ||
| data = response.json() |
There was a problem hiding this comment.
There still seems to be an issue with this variable.
There was a problem hiding this comment.
I added some checks for that variable not existing, tested with sudo python3 autopwn.py -t 158.174.109.227
GamehunterKaan
approved these changes
Feb 27, 2024
This was referenced Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NIST retired the 1.0 APIs that this project relied upon on Dec 18, 2023. This is causing the nist_search module to receive a 404 error for every keyword search and return no data. There are currently 2 issues #46 and #47 that this PR would fix, both the same root cause.
See the timeline of the API retirement here
The endpoint was changed from 1.0 to 2.0, the keyword parameter is now "keywordSearch" instead of "keyword", and the 2.0 API requires the API key in a header instead of a get parameter.
The response schema has also changed, so I had to update FindVulns to account for that as well.