Revise boots of ostara functionality #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* As discussed in the Gamemode 4 Discord, the Boots of Ostara's ability to place crops was never really useful as the module ticks too slowly to be better than placing by hand, and pig tractors exists for automated usage. Hence, that functionality was removed. The ability for players and armor stands to spread grass blocks remains. * The custom crafting recipe for Boots of Ostara now preserves the NBT of the leather boots used in the recipe, such as CustomModelData, enchantments, and shamirs. The Lore tag is prepended to instead of overriden, as well, to preserve existing lore when present. * Instead of checking whether the Boots of Ostara are equipped separately from the player holding a grass block, there is now a predicate that checks for both at once, since holding a grass block while wearing boots of ostara is the only remaining feature other than block_desire_lines (which isn't part of the 'main' function).
Bloo-dev
approved these changes
Apr 25, 2021
Bloo-dev
added
feature-update
Bloo-dev
added
the
server-testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in the Gamemode 4 Discord, the Boots of Ostara's ability to place crops was never really useful as the module ticks too slowly to be better than placing by hand, and pig tractors exists for automated usage. Hence, that functionality was removed. The ability for players and armor stands to spread grass blocks remains.
The custom crafting recipe for Boots of Ostara now preserves the NBT of the leather boots used in the recipe, such as
CustomModelData, enchantments, and shamirs. TheLoretag is prepended to instead of overriden, as well, to preserve existing lore when present.Instead of checking whether the Boots of Ostara are equipped separately from the player holding a grass block, there is now a predicate that checks for both at once, since holding a grass block while wearing Boots of Ostara is the only remaining feature other than
block_desire_lines(which isn't part of themainfunction).