Misc cleanups & include_jobs: on-failure addition
#13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…instead of `env` While we're here — use `octokit.actions` to get jobs instead of `octokit.request`, dist size 1.9M -> 1.5M Now octkit responses are typed, so fix the single issue.
ojab
force-pushed
the
misc_cleanups
branch
3 times, most recently
from
cf9f3c5
to
cb16ec8
Compare
…290K `IncomingWebhook` arguments are typed, so we can remove our types
And while we're here — don't generate jobs attachment if it's not needed & mart `include_jobs` argument in README as required as it is
Also should fix an issue with GitHub Enterprise urls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I actually want to include jobs only if workflow has failed and while working on it I made some cleanups.
No major changes, basically package updates, more types and eslint.
As a bonus — dist size changed from 1.5M to 281K.