Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add files for github actions, docker compose, dockerfile #22

Merged
merged 3 commits into from
Apr 8, 2023
Merged

Add files for github actions, docker compose, dockerfile #22

merged 3 commits into from
Apr 8, 2023

Conversation

maexled
Copy link
Contributor

@maexled maexled commented Apr 6, 2023

@maexled maexled added the maintenance Relates to project maintenance and does not directly affect the program label Apr 6, 2023
@maexled maexled requested a review from madebyTimo April 6, 2023 15:45
@maexled maexled self-assigned this Apr 6, 2023
@maexled maexled marked this pull request as draft April 6, 2023 15:47
@maexled maexled marked this pull request as ready for review April 6, 2023 16:13
madebyTimo
madebyTimo reviewed Apr 7, 2023
View reviewed changes
Copy link
Contributor

@madebyTimo madebyTimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We normally have the docker-compose-dev-e2e in the frontend to be able to run backend and frontend at the same time. Should I add it?

The other files look fine.

The Sonarqube workflow file is missing. Should it also be added in this PR?

@maexled
Copy link
Contributor Author

maexled commented Apr 7, 2023 •
edited
Loading

We normally have the docker-compose-dev-e2e in the frontend to be able to run backend and frontend at the same time. Should I add it?

Yes, please add it.

The Sonarqube workflow file is missing. Should it also be added in this PR?

The sonarqube file is there? Or is there somehing more needed?

@madebyTimo
Copy link
Contributor

madebyTimo commented Apr 8, 2023 •
edited
Loading

Oh sorry I overlooked the sonarqube file because it was not newly added

@maexled maexled merged commit 6ac9617 into main Apr 8, 2023
@maexled maexled deleted the maintenance/add-devops-files branch April 8, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madebyTimo madebyTimo madebyTimo approved these changes

Assignees

@maexled maexled

Labels
maintenance Relates to project maintenance and does not directly affect the program
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maexled @madebyTimo