Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArrayVList #66

Merged
merged 6 commits into from Dec 30, 2021
Merged

ArrayVList #66

merged 6 commits into from Dec 30, 2021

Conversation

Gaming32
Copy link
Owner

ArrayVLists are ArrayLists that are visualized in ArrayV. There is no support for transposed ArrayLists/arrays of ArrayLists yet (so no Radix or Feature Sort yet). However, it is still available for other sorts like Stable Quick Sort and Drop Merge Sort.

@Gaming32 Gaming32 added enhancement New feature or request new-feature labels Jul 18, 2021
Copy link
Collaborator

@EmeraldBlock EmeraldBlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't review ArrayVList.java because I don't know much about AbstractList, but I'm wondering, why are lists directly used instead of accessed through "proxy" methods like with arrays?

src/utils/Sounds.java Show resolved Hide resolved
src/utils/Writes.java Outdated Show resolved Hide resolved
src/main/ArrayVisualizer.java Outdated Show resolved Hide resolved
src/sorts/hybrid/DropMergeSort.java Outdated Show resolved Hide resolved
@Gaming32 Gaming32 removed the request for review from aphitorite July 30, 2021 12:20
@Gaming32
Copy link
Owner Author

Are we all good for this PR then?

Copy link
Collaborator

@EmeraldBlock EmeraldBlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't understand internal details well but looks cool

@Gaming32 Gaming32 merged commit c7e095f into main Dec 30, 2021
@Gaming32 Gaming32 deleted the arrayvlist branch December 30, 2021 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request new-feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants