Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced Shuffle Editor #70

Merged
merged 41 commits into from Aug 9, 2021
Merged

Advanced Shuffle Editor #70

merged 41 commits into from Aug 9, 2021

Conversation

Gaming32
Copy link
Owner

This editor allows you to chain shuffles as they run. This PR still allows you to use the old system if you like.

Copy link
Collaborator

@EmeraldBlock EmeraldBlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't really review internals; comments are primarily on things I noticed from testing and from a scan of what each thing does

some of this stuff was previously brought up in discord

still think double list is better

shuffle_editor_test.py Outdated Show resolved Hide resolved
src/dialogs/CustomImageDialog.java Outdated Show resolved Hide resolved
src/dialogs/ImportSortDialog.java Show resolved Hide resolved
src/dialogs/ShuffleDialog.java Outdated Show resolved Hide resolved
src/dialogs/ShuffleDialog.java Outdated Show resolved Hide resolved
Noisily sorted.txt Show resolved Hide resolved
src/main/ArrayManager.java Outdated Show resolved Hide resolved
src/main/ArrayManager.java Show resolved Hide resolved
src/dialogs/ShuffleDialog.java Show resolved Hide resolved
src/utils/ShuffleInfo.java Show resolved Hide resolved
@Gaming32
Copy link
Owner Author

Gaming32 commented Aug 6, 2021

So is it ready then @EmeraldBlock?

@EmeraldBlock
Copy link
Collaborator

I haven't yet tested the new changes, but if you think it's all fine, yeah

Copy link
Collaborator

@EmeraldBlock EmeraldBlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review time tm

src/dialogs/ShuffleDialog.java Show resolved Hide resolved
src/utils/ShuffleGraph.java Outdated Show resolved Hide resolved
src/main/ArrayManager.java Show resolved Hide resolved
src/dialogs/ShuffleDialog.java Outdated Show resolved Hide resolved
src/dialogs/ShuffleDialog.java Outdated Show resolved Hide resolved
src/utils/ShuffleGraph.java Show resolved Hide resolved
Noisily sorted.txt Outdated Show resolved Hide resolved
@Gaming32 Gaming32 merged commit 9f03ab8 into main Aug 9, 2021
@Gaming32 Gaming32 deleted the new-shuffles branch August 10, 2021 20:17
@Gaming32 Gaming32 added enhancement New feature or request new-feature labels Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request new-feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants