Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats config #75

Merged
merged 17 commits into from Dec 31, 2021
Merged

Stats config #75

merged 17 commits into from Dec 31, 2021

Conversation

Gaming32
Copy link
Owner

Will close #40

@Gaming32 Gaming32 marked this pull request as ready for review December 30, 2021 19:22
@Gaming32 Gaming32 marked this pull request as draft December 30, 2021 19:23
NOTE: This does *not* change spacing between lines, so larger text sizes may look strange
@Gaming32 Gaming32 marked this pull request as ready for review December 30, 2021 19:40
Copy link
Collaborator

@EmeraldBlock EmeraldBlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review:tm:

src/main/ArrayVisualizer.java Outdated Show resolved Hide resolved
src/main/ArrayVisualizer.java Outdated Show resolved Hide resolved
src/main/ArrayVisualizer.java Outdated Show resolved Hide resolved
src/main/ArrayVisualizer.java Outdated Show resolved Hide resolved
src/main/ArrayVisualizer.java Show resolved Hide resolved
src/main/ArrayVisualizer.java Outdated Show resolved Hide resolved
src/main/ArrayVisualizer.java Outdated Show resolved Hide resolved
src/main/ArrayVisualizer.java Outdated Show resolved Hide resolved
Copy link
Collaborator

@EmeraldBlock EmeraldBlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on the new stuff and the old stuff

src/main/ArrayVisualizer.java Show resolved Hide resolved
src/main/ArrayVisualizer.java Outdated Show resolved Hide resolved
src/utils/Statistics.java Outdated Show resolved Hide resolved
src/main/ArrayVisualizer.java Outdated Show resolved Hide resolved
src/main/ArrayVisualizer.java Show resolved Hide resolved
@EmeraldBlock
Copy link
Collaborator

hopefully I understood my Java properly, feel free to revert/edit what I did if it's bad

@Gaming32
Copy link
Owner Author

So are we all ready for a merge then?

@EmeraldBlock
Copy link
Collaborator

looks good

@Gaming32
Copy link
Owner Author

👍

@Gaming32
Copy link
Owner Author

I'll merge it when the checks complete

@Gaming32 Gaming32 merged commit a1f34e5 into main Dec 31, 2021
@Gaming32 Gaming32 deleted the stats-config branch December 31, 2021 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More statistics customizability
2 participants