Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Groovy scripting #82

Merged
merged 81 commits into from Apr 4, 2022
Merged

Groovy scripting #82

merged 81 commits into from Apr 4, 2022

Conversation

Gaming32
Copy link
Owner

This introduces a very substantial scripting API. You can write for this API using the Apache Groovy scripting language. If you'd like to learn the basics of Groovy, see here: https://groovy-lang.org/syntax.html.

@Gaming32
Copy link
Owner Author

Gaming32 commented Mar 4, 2022

@EmeraldBlock I have written Javadocs for the entire PR. Is that enough of a summary?

Copy link
Collaborator

@EmeraldBlock EmeraldBlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looked through code (but not at implementation specifics) and tried out the API a little; thoughts written in discord

Copy link
Collaborator

@EmeraldBlock EmeraldBlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

proper GitHub review of my still-standing thoughts in discord

@Gaming32
Copy link
Owner Author

Gaming32 commented Apr 4, 2022

So are we ready to merge now?

@EmeraldBlock
Copy link
Collaborator

think so

@EmeraldBlock EmeraldBlock merged commit 57bb8e3 into main Apr 4, 2022
@EmeraldBlock EmeraldBlock deleted the groovy-scripting branch April 4, 2022 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request new-feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants