working forward on test coverage

Gandi · Jul 27, 2016 · 8f7985a · 8f7985a
1 parent 961ae41
commit 8f7985a
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 9 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,7 @@ Hubot-phabs Changelog
 
 ### 1.2.3 - wip
 - improve search result feedbacks
+- fix full test coverage for feeds and search
 
 ### 1.2.2 - 2016-07-27
 - fix task creation

diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "hubot-phabs",
   "description": "A hubot plugin for communication with a Phabricator instance.",
-  "version": "1.2.2",
+  "version": "1.2.3",
   "author": {
     "name": "mose",
     "email": "mose@gandi.net",

diff --git a/scripts/phabs_commands.coffee b/scripts/phabs_commands.coffee
@@ -202,5 +202,5 @@ module.exports = (robot) ->
           for task in payload.result.data
             msg.send "#{process.env.PHABRICATOR_URL}/T#{task.id} - #{task.fields['name']}"
           if payload.result.cursor.after?
-            msg.send "... and there is more."
+            msg.send '... and there is more.'
     msg.finish()
diff --git a/test/phabs_feeds_test.coffee b/test/phabs_feeds_test.coffee
@@ -67,7 +67,7 @@ describe 'phabs_feeds module', ->
         "epoch": "1469408232"
       }'
       room.robot.http('http://localhost:8080')
-        .path('/Hubot/phabs/feeds')
+        .path('/hubot/phabs/feeds')
         .post(postData) (err, res, payload) ->
           done()
 
@@ -84,7 +84,7 @@ describe 'phabs_feeds module', ->
         'Bug Report': {
           phid: 'PHID-PROJ-qhmexneudkt62wc7o3z4',
           feeds: [
-            "room1"
+            'room1'
           ]
         },
         'project with phid': { phid: 'PHID-PROJ-1234567' },
@@ -139,7 +139,7 @@ describe 'phabs_feeds module', ->
               }
             }
           ],
-          'maps': {},
+          'maps': { },
           'query': {
             'queryKey': 'XQHShcroSRib'
           },
@@ -166,7 +166,7 @@ describe 'phabs_feeds module', ->
         "epoch": "1469085410"
       }'
       room.robot.http('http://localhost:8080')
-        .path('/Hubot/phabs/feeds')
+        .path('/hubot/phabs/feeds')
         .post(postData) (err, res, payload) ->
           done()
 
@@ -185,7 +185,7 @@ describe 'phabs_feeds module', ->
         'Bug Report': {
           phid: 'PHID-PROJ-qhmexneudkt62wc7o3z4',
           feeds: [
-            "room1"
+            'room1'
           ]
         },
         'project with phid': { phid: 'PHID-PROJ-1234567' },
@@ -240,7 +240,7 @@ describe 'phabs_feeds module', ->
               }
             }
           ],
-          'maps': {},
+          'maps': { },
           'query': {
             'queryKey': 'XQHShcroSRib'
           },
@@ -267,7 +267,7 @@ describe 'phabs_feeds module', ->
         "epoch": "1469085410"
       }'
       room.robot.http('http://localhost:8080')
-        .path('/Hubot/phabs/feeds')
+        .path('/hubot/phabs/feeds')
         .post(postData) (err, res, payload) ->
           done()