-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite Comparator impls to get rid of the need for old_impl_check
#75
Comments
I've been thinking about how to approach this, but it seems like the new rules will make comparators a lot more limited. |
@apasel422 Can you elaborate on the problems so I can pester core devs with it? |
@gankro Sure, let me organize my thoughts. |
@gankro I may be wrong, actually. I thought there was an issue relating to "early" vs. "late" binding of the types that a comparator can compare, but maybe not. Let me submit a PR with my proposed changes to see how it turns out. |
I'm currently trying to port it to associated types as well (need to learn this crap at some point) |
(getting walled on TreeMap's |
I actually don't think associated types will work in general -- in particular, I think |
How did a type ever satisfy these bounds anyway? |
Do you mean In any case, see #76 for a fix. |
I remember there being problems with doing something like |
No description provided.
The text was updated successfully, but these errors were encountered: