Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add IntoIterator impls #121

Merged
merged 1 commit into from
Feb 20, 2015
Merged

add IntoIterator impls #121

merged 1 commit into from
Feb 20, 2015

Conversation

apasel422
Copy link
Contributor

No description provided.

@Gankra
Copy link
Owner

Gankra commented Feb 20, 2015

Travis build fails, but it looks like it might be nightly update stuff.

@apasel422
Copy link
Contributor Author

Yeah, it's an issue with changes to Send. I'm not familiar enough with ParVec to update it.

@Gankra
Copy link
Owner

Gankra commented Feb 20, 2015

Currently working on updating to alpha2

@Gankra
Copy link
Owner

Gankra commented Feb 20, 2015

I'm 90% sure compare::Borrow just doesn't work with new coherence

@apasel422
Copy link
Contributor Author

Can you elaborate? (Code example, error message?) I'm not seeing any problems with it on rustc 1.0.0-nightly (dfc5c0f1e 2015-02-18) (built 2015-02-19).

@Gankra
Copy link
Owner

Gankra commented Feb 20, 2015

I'm running a build of master from last night, where new coherence rules have kicked in and Q: BorrowFrom<K> -> K: Borrow<Q>.

But I think I might have figured it out.

@Gankra
Copy link
Owner

Gankra commented Feb 20, 2015

Got it working 💖

@apasel422
Copy link
Contributor Author

Rebased.

Gankra added a commit that referenced this pull request Feb 20, 2015
@Gankra Gankra merged commit 1098a26 into Gankra:master Feb 20, 2015
@Gankra
Copy link
Owner

Gankra commented Feb 20, 2015

wooooo

@apasel422 apasel422 deleted the into_iter branch February 20, 2015 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants