Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update everything to work with alpha2 #122

Merged
merged 2 commits into from
Feb 20, 2015
Merged

Update everything to work with alpha2 #122

merged 2 commits into from
Feb 20, 2015

Conversation

Gankra
Copy link
Owner

@Gankra Gankra commented Feb 20, 2015

Collections got renamed, traits got changed, markers changed, coherence changed.

This is basically the "minimum viable product" to get us compiling under alpha2. Doesn't work yet because our dependencies are busted.

I'm totally not clear on the appropriate fix to do to ParVec. I just tossed in a 'static, but the comment in there about static is pretty scary.

@Gankra
Copy link
Owner Author

Gankra commented Feb 20, 2015

Actually correction: this builds, but our dev dependencies are busted.

@Gankra
Copy link
Owner Author

Gankra commented Feb 20, 2015

Double correction: I just needed to cargo update.

@Gankra
Copy link
Owner Author

Gankra commented Feb 20, 2015

Sweet, this cargo tests on my random master snapshot from last night.

@Gankra
Copy link
Owner Author

Gankra commented Feb 20, 2015

r? @apasel422

The only thing dubious about this is the ParVec change, which I believe can only potentially make the collection useless in some situations, and not actually do anything bad. Seems like an acceptable hack so that we can fix land this and start fixing everything else.

@apasel422
Copy link
Contributor

r+ This looks good overall, in terms of getting things building. The ParVec change seems fine for now.

However, I would like to remove the type parameter from Natural. Multidispatch works, and while it may make inference fail sometimes, it more accurately models the situation and allows us to avoid the ugliness of natural() and PhantomData. Along the same lines, I think it might be possible to simplify the Borrow comparator using multidispatch as well. I can make these changes later, once I've had a chance to experiment with the alpha myself. In order to convert both of these, I think the CompareExt trait needs to change, but I have some ideas for how to support this and will begin investigating.

@Gankra
Copy link
Owner Author

Gankra commented Feb 20, 2015

Landing as good enough for now. Will iterate in the future.

Gankra added a commit that referenced this pull request Feb 20, 2015
Update everything to work with alpha2
@Gankra Gankra merged commit ff225bc into master Feb 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants