APIS-3408 Allow Avro to support generation of nullable nested objects #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstorer
approved these changes
Sep 5, 2019
tkuhlman
approved these changes
Sep 5, 2019
| if goFile != nil { | ||
| return nil, fmt.Errorf("name %q is not unique in go files at path %q", name, path) | ||
| // It's necessary to loop over all the decls and their specs to ensure the typeSpec.Name.Name matches our name | ||
| // because the `ast.FilterPackage` doesn't filter out declarations that only have the wanted itemName as a |
There was a problem hiding this comment.
Interesting it doesn't filter out when the name is an argument. I bet that was a pain to find.
There was a problem hiding this comment.
It wasn't too terrible but not immediately obvious what was going on. The ast package doesn't give you the ability to easily filter these out like we need unfortunately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.