Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get long-running tests clean (only React examples) #98

Merged
merged 3 commits into from Oct 14, 2018
Merged

Get long-running tests clean (only React examples) #98

merged 3 commits into from Oct 14, 2018

Conversation

tudorpavel
Copy link
Contributor

@tudorpavel tudorpavel commented Oct 14, 2018 •
edited

Issue: #91

This fixes only the React examples, I couldn't run the React Native examples properly in order to see what fails. I tried executing the same commands from test_react_native_directory.js:

$ react-native build
Scanning folders for symlinks in /home/me/workspace/ReactStateMuseum/ReactNative/ApolloLinkState/node_modules (18ms)

  Unrecognized command 'build'
  Run react-native --help to see list of all available commands

@tudorpavel
[apollo-link-state] make exhaustive test pass
705798f 
  - upgrade react-apollo
  - add yarn v1.10.1 integrity hashes
@tudorpavel
[react-automata] make exhaustive test pass
69f34f2 
  - add flag because create-react-app v2 `test` exits when no tests found: facebook/create-react-app#5283
@tudorpavel
[reduxx] make exhaustive test pass
a38ee8b 
  - upgrade to reduxx v13, solution discussed here: https://github.com/msteckyefantis/reduxx/issues/5
  - add yarn.lock file
@GantMan GantMan added the hacktoberfest-accepted Good for October credit in Hacktoberfest label Oct 14, 2018
@GantMan GantMan merged commit a056eac into GantMan:master Oct 14, 2018
@GantMan
Copy link
Owner

GantMan commented Oct 14, 2018

Welcome to the contributors!

@tudorpavel tudorpavel deleted the fix-react-examples branch October 14, 2018 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
hacktoberfest-accepted Good for October credit in Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tudorpavel @GantMan