Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GuiControl::setVariable(const char *value) unable to take type #1408

Closed
Azaezel opened this issue Sep 6, 2015 · 4 comments
Closed

GuiControl::setVariable(const char *value) unable to take type #1408

Azaezel opened this issue Sep 6, 2015 · 4 comments
Labels
Milestone

Comments

@Azaezel
Copy link
Contributor

Azaezel commented Sep 6, 2015

Recently rolled in 77b9600#diff-e4ea6d75e6c53e52a5cc5049e7cd21ae

Broke an old code-share http://www.garagegames.com/community/forums/viewthread/38929/1#comment-303162

potential resolutions:

  1. revert back to
    if ( mConsoleVariable[0] )
    Con::setVariable(mConsoleVariable, mTextBuffer.getPtr8());
  2. add a StringBuffer flag defaulting to non-formated.
  3. a brighter idea.
@crabmusket
Copy link
Contributor

  1. fix the old shared example to work with the way the class works now?

@Azaezel
Copy link
Contributor Author

Azaezel commented Sep 8, 2015

@crabmusket
Copy link
Contributor

Option 1) is looking attractive

@crabmusket crabmusket added the Bug label Sep 8, 2015
@crabmusket crabmusket added this to the 3.8 milestone Sep 8, 2015
@Azaezel
Copy link
Contributor Author

Azaezel commented Sep 8, 2015

It'd be quickest, surely. Two was listed since adding method options is a bit more self-documenting than looking up usage-cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants