Volumetric Fog with corrections #1445
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into development
…ort was added, please review.
…R on, and hooks the fog into the ambient light color so that it correctly operates with day/night cycles.
|
Nice! |
|
A few of the shaders have text comments from the vehicle scripts. Example https://github.com/GarageGames/Torque3D/pull/1445/files#diff-b4098ac45d8e0fda828ca2bd1871bb21R23 |
|
Yeah, it looks like there's just several chunks of this that are a bit weird. I'm working through the whole thing manually to try and shore up those weird bits that snuck past everyone the first go around. |
fillin for fallbacks for filesystem funcs
As I nor az have been able to find any issues with this so far, I'll push this through. We can handle any emergent problems as they come up, but so far it looks solid.
|
Redid this with #1478 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the Winterleaf PR #1059, this adds corrections so that it works with HDR being active, and also utilizes ambient color so that it works with day/night cycles, rather than being unlit during low-light settings.