Fixes AbstractPolyList::addBox(). Complete each face with missing 2nd triangle. #1782
+9
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I'll definitely check on this. |
|
Yes, this is probably an issue introduced during DX11 port because we had to remove fan topology from the renderer. |
ghost
reviewed
Oct 8, 2016
| plane(v1, v2, v3); | ||
| end(); | ||
| // Second triangle |
There was a problem hiding this comment.
We could also use 4 vertices strip, but anyway nothing really change in practice.
Thank you @pacomont !
ghost
added this to the 
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
This is a minefield, which is a class inherited from Trigger.
Ok, and because Military intelligence should work, enemies (Tanks) must avoid go across it, because it's his own minefield! Then I added the minefield to NavMesh. Then I realized that I had to add a buildPolyList function to my class, which uses AbstractPolyList::addBox().
And as you can see, the edges of the box is not completely etched from the NavMesh.
Looking at AbstractPolyList::addBox() I saw that only add one triangle per face, so I fix it and that the result:
With this PR it's added the second triangle to the face, but I can't say If this was originally made by design, or if breaks something else...