Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve cinterface #2366

wants to merge 20 commits into
base: development


Copy link

commented Aug 3, 2019

CInterface improvements

  • Expand EngineAPI type definitions (replaces #2241)
  • Fix name-clashing in script-exposed classes (these have not been an issue in TorqueScript because it doesn't fail, it just picks the first definition it finds).
  • Update the EngineAPI, a little bit of simplification over the changes made in #2248
  • Improve the integration of the CInterface into existing systems
  • Expose SimPersistID to the EngineAPI
  • Improve EngineAPI export, less guess-work and compiler-dependency

Breaking changes

Name-clash fixes means that some members have been renamed, possibly breaking any scripts using these members.
AFX Members:

  • Method afxPhraseEffectData::addEffect -> pushEffect
  • Method afxMagicSpellData::addCastingEffect -> pushCastingEffect
  • Method afxMagicSpellData::addLaunchEffect -> pushLaunchEffect
  • Method afxMagicSpellData::addDeliveryEffect -> pushDeliveryEffect
  • Method afxMagicSpellData::addImpactEffect -> pushImpactEffect
  • Method afxEffectronData::addEffect -> pushEffect
  • Method afxEffectGroupData::addEffect -> pushEffect

Other Members:

  • Field GuiSpeedometerHud::mColor -> mNeedleColor (Maybe we could just use the parent class' mColor here instead?)
  • Callback TriggerComponent::onEnterViewCmd ->onEnterView
  • Callback TriggerComponent::onExitViewCmd ->onExitView
  • Callback TriggerComponent::onUpdateInViewCmd ->onUpdateInView
  • Callback TriggerComponent::onUpdateOutOfViewCmd ->onUpdateOutOfView
  • Field PostEffect::isEnabled -> enabled
  • Method GuiFilterCtrl::identity -> resetFiltering
  • Field SFXDescription::reverbModTime -> reverbModDepth (dunno if it pointed to time or depth before, now there is one for each)
  • Field GuiScriptNotifyCtrl::onChildAdded -> notifyOnChildAdded
  • Field GuiScriptNotifyCtrl::onChildRemoved -> notifyOnChildRemoved
  • Field GuiScriptNotifyCtrl::onChildResized -> notifyOnChildResized
  • Field GuiScriptNotifyCtrl::onParentResized -> notifyOnParentResized
  • Field GuiScriptNotifyCtrl::onResize -> notifyOnResize
  • Field GuiScriptNotifyCtrl::onLoseFirstResponder -> notifyOnLoseFirstResponder
  • Field GuiScriptNotifyCtrl::onGainFirstResponder -> notifyOnGainFirstResponder

Other (possibly breaking) changes

I also changed the default value of UndoManager::pushCompound from """" to "". Would like a review of whether this is valid or a misunderstanding on my part.

@lukaspj lukaspj marked this pull request as ready for review Aug 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
1 participant
You can’t perform that action at this time.