New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Action for solder edges of nearest terrains. #566
Action for solder edges of nearest terrains. #566
Conversation
Just a warning for anyone looking to merge this. It uses C++11 features so requires VS2012 or newer. |
Outside 2014 year. C++11. |
I'll second tim that I at least won't be able to roll in and doublecheck anything with c++11 dependencies. |
Some features of c++11 as "auto", are supported in VS2010. Currently the generator project have support for VS2008, would have to discuss whether it is time for deprecate. Will the new committee decision, to lift the ban on c++11. My personal opinion is YES to c++11 |
Don't worry guys -- we won't just merge in a Pull Request that requires it. We won't move onto C++11 without it being a conscious effort. The reasons for and against it across multiple platforms and compilers would need to be considered. What I would recommend is that any Pull Request that has been written to require C++11 to be rewritten to not require it. Unfortunately, that looks like a number of them lately. |
I ended up just ditching 2008 standard for 2013 express. I havent seen any issues with using it instead of 2008 yet other than I had to merge the other pull request by signmotion to get it to compile. Figured since so many people are using C++11 I might as well update if express handles what I need. |
Are a lot of people using C++11? Certainly signmotion has posted a number of Pull Requests that are making use of it, but I don't know if that represents the general user base. I personally have mixed feelings about it (especially the auto keyword). Also, I should probably clarify my last statement. Right now my statement is true, but it will ultimately be up to the new people that have write access to the repo to decide. I can offer my opinion of each Pull Request if asked, and may offer an opinion even if not asked. :) I'm using T3D on my own personal projects after all, and will continue to have a future interest in it. But we can't both give autonomy to the new group and then also require that they check in all decisions with GG, so the decision will have to be theirs to make. I'll probably move over to use my @DavidWyand account (for Gnometech Inc.) rather than my @DavidWyand-GG account when I'm just offering my personal opinion so as to avoid confusion. |
My problem with jumping the gun on C++11 is that you've just completely alienated everybody who doesn't have the latest Visual Studio and other development tools simply because of their work requirements. Not everybody can afford to upgrade to Visual Studio 2013. Myself I'm currently stuck with Windows XP because of embedded development tools issues and latest Visual Studio isn't supported on that OS. So I'm out of luck and so is anybody else that uses Visual Studio 2008 to 2010. |
This discussion to exceed the limits of PR. I suppose to continue on the forum. |
The Steering Committee has decided internally to not accept C++11 submissions at this time, in order to retain support for VS2008. 2008 does have access to the Sorry @signmotion - we really do appreciate the hard work you've put into your pull requests! We will discuss whether we can assign one or two members of the committee to revise your PRs to not use C++11 features. If you'd like to do it yourself that'd be great, but we understand that it's tedious work. |
Removed all the C++ 11 code Fixed a bug where you couldn't paint the last pixel on the edges.
Download the test level.