further cleanup for error splitting mesh and image filenames #416 #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree with Nathan - a good solution would be to actually expose tokenisation on arbitrary delimiters to scripts. I'd prefer that solution if anyone were to work on it. |
|
Glad I wasted the time to do a new PR for these changes. |
|
Sorry @Smally that was my bad. |
|
Point is, in the time to cleanup the last one this could have been done with the token route instead. That's all. For the record though, I ALSO agree with the token route suggested by Nathan :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup for bug/fix #416 to gracefully handle spaces in file names for world and shape editors.