Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please pull this fix for VS2008 project generation #92

Closed
wants to merge 1 commit into from

Conversation

Dinno
Copy link

@Dinno Dinno commented Oct 16, 2012

Pathes to includes and libs of DX SDK were not added

Pathes to includes and libs of DX SDK were not added
@dottools
Copy link

Please do not do this as this is the wrong way to configure Microsoft SDKs like this for Visual Studio 2008 and older. Instead the SDK installers typically configure your Project and Solutions -> VC++ Directories for you of which was removed since Visual Studio 2010 hence why this project generator operation was done for VC10 and later. If the SDK installer did not do it for you automatically, usually the case when you don't run the SDK installer as Administrator then you're suppose to manually enter the paths into the fore mentioned Visual Studio options configuration tree.

Doing this for VS9 and older you're just clobbering the include and lib paths for no reason for those who prepared the SDKs properly. Again this is not the right way to do it for Visual Studio 2008 and older releases.

@just-bank
Copy link
Contributor

Agree with @dottools

@Dinno
Copy link
Author

Dinno commented Oct 21, 2012

Ok. I see that you are right. There is only one question. Why DX SDK haven't installed this configuration?

@Dinno Dinno closed this Oct 21, 2012
@Dinno
Copy link
Author

Dinno commented Oct 21, 2012

Here https://developer.valvesoftware.com/wiki/Compiling_under_VS2008 under "Install the DirectX SDK (for shaders)" header, I see instructions for manual configuration of DX SDK directories. From this I make conclusion, that DS SDK can not configure VS2008 itself. May be we should eliminate this part of manual config by adding it into project generator?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants