Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed incompatibility with livereload==2.4.1 #43

Closed
wants to merge 1 commit into from

Conversation

jmc734
Copy link

@jmc734 jmc734 commented Feb 5, 2016

As of version v2.4.1 of the livereload package, they've decided to include a new argument, ignore, when they make their watch() call from Server.watch(). This causes a TypeError so I just changed the sphinx_autobuild watch() signature to capture an undefined number of parameters.

@jmc734
Copy link
Author

jmc734 commented Feb 5, 2016

I've submitted a pull request to the livereload project to add backwards compatibility on their end. It's yet to be pulled.

@adamchainz
Copy link

+1

@GaretJax
Copy link
Contributor

Fixed in #41

@GaretJax GaretJax closed this Feb 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants